Request parser interface #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Server.php
Outdated
Member
There was a problem hiding this comment.
I'm all for (somehow) injecting the parser instance to use here 👍
However, unfortunately the parser is stateful, meaning a single instance can't really be reused for multiple connections.
Author
|
Hm, I didn't realize that. Maybe we could inject a factory instance? The default factory can be extended in the future once react/http has multiple parsers to return the fastest one. I made an interface so that the user can still inject a custom factory and return a different parser. |
This was referenced Oct 13, 2017
Member
|
Hey @yuloh are there any updates on this? I'm closing this because we want to keep this internal, however if you're still working on this we rather select the fastest parser internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch creates an interface for the RequestParser and injects it.
Reasoning being, I am working on some alternative parsers using C extensions. It would be nice to implement something like the event loop's factory and inject the fastest parser possible.
I do not know of a way to enforce that the parser emits
headerswith aRequestobject and body buffer.I made injection of the parser optional to prevent a BC break.